[alsa-devel] [PATCH] eukrea-tlv320: add support for our i.MX25 board

Mark Brown broonie at opensource.wolfsonmicro.com
Sat Jun 19 02:29:38 CEST 2010


On Fri, Jun 18, 2010 at 09:10:33AM +0200, Eric Bénard wrote:

> This Kconfig seems to have unecessary things into it :
> - config SND_MXC_SOC_SSI :
> 	not used in the kernel

That's supposed to be being used to build the SSI driver as a separate
module.

> - 1st board :

It'd be helpful to use actual names to make your mails legible,
otherwise it's like Outlook style mail.

> 	depends on SND_IMX_SOC
> 	select SND_MXC_SOC_SSI
> - 2nd board :
> 	select SND_MXC_SOC_SSI
> 	but doesn't depends on SND_IMX_SOC
> - 3rd board :
> 	select SND_IMX_SOC
> 
> Do you have any idea what SND_MXC_SOC_SSI is used for ?
> 
> Please find attached a patch which should clean this Kconfig. If
> it's ok for you, I'll submit it the right way.

This isn't the best approach, converting things so SND_IMX_SOC is a menu
and we don't need to reference that at all from the individual items
would be nicer since it saves having to do per-board handling.


More information about the Alsa-devel mailing list