[alsa-devel] [PATCH 2/5] ALSA: usb-audio: unify UAC macros and struct names

Daniel Mack daniel at caiaq.de
Thu Jun 17 17:26:26 CEST 2010


(hint, hint: don't top-post :))

On Thu, Jun 17, 2010 at 08:21:22AM -0700, Alex Lee wrote:
> It will not help existing codes, I agree.  But it may make writing new UAC2
> specific code easier?

Not as long as most of the code stays hybrid for both versions. If there
were versions of these enum values for both UAC1 and UAC2, you would
need to choose one of them in the parser codes. Which one you go for
doesn't actually make any difference as they're both the same, but the
code would read as if it was specific to any version.

I'd say this would add more to the confusion, and not ease any.


Daniel



More information about the Alsa-devel mailing list