[alsa-devel] [PATCH RFC 1/3] sound: ac97: Add GPIO manipulation hooks

[Takashi Iwai]

At Tue, 15 Jun 2010 17:02:53 +0100,
Mark Brown wrote:
> 
> On Tue, Jun 15, 2010 at 05:55:45PM +0200, Manuel Lauss wrote:
> > Add callbacks to struct snd_ac97 to set and retrieve ac97 codec
> > GPIO status.
> 
> > Signed-off-by: Manuel Lauss <manuel.lauss at googlemail.com>
> 
> CCing in Takashi since this is generic AC'97 stuff.

Thanks.

> > ---
> >  include/sound/ac97_codec.h |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/sound/ac97_codec.h b/include/sound/ac97_codec.h
> > index 4940045..db3aee1 100644
> > --- a/include/sound/ac97_codec.h
> > +++ b/include/sound/ac97_codec.h
> > @@ -437,6 +437,8 @@ struct snd_ac97_bus_ops {
> >  	unsigned short (*read) (struct snd_ac97 *ac97, unsigned short reg);
> >  	void (*wait) (struct snd_ac97 *ac97);
> >  	void (*init) (struct snd_ac97 *ac97);
> > +	void (*setgpio) (struct snd_ac97 *ac97, unsigned short gpio);
> > +	unsigned short (*getgpio) (struct snd_ac97 *ac97);

Can this be handled simply in read/write callbacks in the controller
side?  In callbacks, you can check whether reg == AC97_GPIO_STATUS and
handle differently for such an access.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe alsa-devel" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html