[alsa-devel] [PATCH v2 1/3]AsoC/nuc900: patch for SUBSTREAM_TYPE', 'PCM_TX' and 'PCM_RX' removal

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Jun 2 12:40:57 CEST 2010

On Wed, Jun 02, 2010 at 10:43:07AM +0100, Liam Girdwood wrote:
> On Wed, 2010-06-02 at 13:54 +0800, Wan ZongShun wrote:
> > This patch is to remove the 'SUBSTREAM_TYPE','PCM_TX' and 'PCM_RX' definition.
> > 
> > There is no need to redefine SNDRV_PCM_STREAM_PLAYBACK as PCM_TX,
> > the SUBSTREAM_TYPE(substream) can be deleted too, the playback or record can be
> > judged by 'if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)' directly rather
> > than 'if (PCM_TX == stype)', which makes the codes easy to read.
> > 
> > Signed-off-by: Wan ZongShun<mcuos.com at gmail.com>

Note here that you're still missing a space betwen your name and e-mail

> All 

> Acked-by: Liam Girdwood <lrg at slimlogic.co.uk>

I've applied all the patches, since I had to fix up the changelogs
anyway I updated the ms to us in the changelog for patch 2.  Thanks.

More information about the Alsa-devel mailing list