[alsa-devel] [PATCH 1/3] ALSA/NUC900: Fix some codes according to Liam for nuc900 alsa driver.

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Jun 1 12:20:05 CEST 2010

On Tue, Jun 01, 2010 at 10:48:19AM +0800, Wan ZongShun wrote:
> Dear Liam & Mark,
> This patch is to fix some codes according to
> Liam for nuc900 alsa driver.

So, these changes look like they're fine but since you've not provided a
changelog it's hard to tell for sure.  It also looks like you've got two
different changes in here, some of the code is adjusting the delays used
between register writes in reset while other bits change the code over
to using the standard method for checking for substream type.

As I said to you yesterday please do read and follow the instructions in
Documentation/SubmittingPatches - in particular, you need to include a
proper changelog in your mail and you shouldn't have any "Dear X" or

> Signed-off-by: Wan ZongShun<mcuos.com at gmail.com>

You're missing a space between your name and the e-mail address too.

More information about the Alsa-devel mailing list