[alsa-devel] [PATCH] ASoC: multi-component: SAMSUNG: Modify the name of I2S driver

Jassi Brar jassisinghbrar at gmail.com
Mon Jul 26 09:22:21 CEST 2010


On Mon, Jul 26, 2010 at 3:57 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On 25 Jul 2010, at 19:07, Chanwoo Choi <cw00.choi at samsung.com> wrote:
>
>> This patch modify the name of I2S driver(S3C64XX/S3C24xx
>> /S3C2412) from "*-iis-*" to "*-i2s-*". The mismatch of I2S name
>> exist in the following sound driver. These files write the
>> "cpu_dai_name" of I2S as "*-i2s-*".
>>
>> - sound/soc/s3c24xx/aquila_wm8994.c : "s3c64xx-i2s-v4-dai"
>> - sound/soc/s3c24xx/goni_wm8994.c : "s3c64xx-i2s-v4-dai"
>> - sound/soc/s3c24xx/smdk64xx_wm8580.c "s3c64xx-i2s-v4-dai"
>> - sound/soc/s3c24xx/jive_wm8750.c : "s3c2412-i2s-dai"
>> - sound/soc/s3c24xx/neo1973_wm8753.c : "s3c24xx-i2s-dai"
>> - sound/soc/s3c24xx/neo1973_gta02_wm8753.c : "s3c24xx-i2s-dai"
>> - sound/soc/s3c24xx/s3c24xx_simtec_hermes.c : "s3c24xx-i2s-dai"
>> - sound/soc/s3c24xx/s3c24xx_simtec_tlv320aic23.c : "s3c24xx-i2s-dai"
>> - sound/soc/s3c24xx/s3c24xx_uda134x.c : "s3c24xx-i2s-dai"
>> - sound/soc/s3c24xx/smartq_wm8987.c : "s3c64xx-i2s-dai.0"
>>
>> or, It is should modify "cpu_dai_name" of sound drvier files
>> instead of modifying the name of I2S driver.
>
> Acked-by: Mark Brown <broonie at opensource.wolfsonmicro.com>
>
> but Jassi really should also comment here.
I already talked to Ben about renaming drivers but he doesn't like the idea
of breaking loadable drivers in distributions and I buy his opinion.
So, Ben really has the say on the matter.

Thanks.


More information about the Alsa-devel mailing list