[alsa-devel] [PATCH] wm8960: fix compile error
broonie at opensource.wolfsonmicro.com
Tue Jul 20 17:18:52 CEST 2010
On Tue, Jul 20, 2010 at 11:02:37PM +0800, Axel Lin wrote:
> 2010/7/20 Mark Brown <broonie at opensource.wolfsonmicro.com>:
> > but please do try to bear in mind the feedback you've previously been
> > given about formatting your patches so they can be easily applied. You
> I'm a little bit confused about the meaning of "formatting your patches"?
> Do you mean my patches cannot be applied by git am command? or?
> ( I tried the git am command with the mail I sent and it looks ok )
In this case the main thing is the subject line which is not consistent
with other subject lines for patches in this area of code. This sort of
stuff is particularly important when you're submitting large numbers of
very small fixes.
> > probably also want to look at the CC list for your patches, I'm not sure
> > why you're CCing Tejun here.
> I get the CC list by get_maintainer.pl. Looks like the script gives me wrong
> CC list.
Yes, you need to apply a bit of taste to the output - it's inclined to
generate false positives. For matches from MAINTAINERS it's good but
for things generated from the git logs it can easily miss people or pick
up people who've been doing kernel wide cleanup work.
More information about the Alsa-devel