[alsa-devel] [PATCH 7/12] wm8940: fix resource reclaim in wm8940_register error path

Guennadi Liakhovetski g.liakhovetski at gmx.de
Thu Jul 15 09:59:16 CEST 2010

On Thu, 15 Jul 2010, Axel Lin wrote:

> I agree that it is good to release resources at the same level,
> where they have been acquired.
> But I prefer to follow the maintainer/author's coding style.

Yeah, unless that "style" is a bug. IMHO this design is just buggy, 
unmaintainable, error-prone, and unjustified.

> For the changes in other drivers, I'd like to see Liam and Mark's comments.
> Or if the driver maintainers request it, I can fix it.

Well, as the author of sound/soc/codecs/wm8978.c, I'd be happy if you 
change it in this way;) And also move the


line from wm8978_unregister() to wm8978_i2c_remove().

Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer

More information about the Alsa-devel mailing list