[alsa-devel] [PATCH] ASoC: TWL4030: Modify codec default settings

[Peter Ujfalusi]

Hello Liam,

On Thursday 28 January 2010 16:14:05 ext Liam Girdwood wrote:
> On Thu, 2010-01-28 at 15:57 +0200, Peter Ujfalusi wrote:
> > Change the legacy default register configuration, which left some
> > internal components on.
> > Now we have either DAPM, or other ways to control these bits,
> > so there is no need to enable them by default.
> >
> > The affected parts:
> > Disable ADCL and ADCR
> > Disable ARXL2 and ARXR2 analog PGA (playback)
> > Disable APLL by default
> 
> Acked-by: Liam Girdwood <lrg at slimlogic.co.uk>
> 
> Btw, should we be expecting more of these or does the twl4030 have full
> DAPM coverage now ?

Well, there are couple of small things that I'm not that satisfied with the 
current implementation:
Some outputs are enabled by default (Headset namely),
Few other defaults, which might not need to be enabled,
In OPTION register the RX2 and TX1 path enable bits are not handled by DAPM,
and there were something else also, which I can not recall...
All in all I think the twl4030 codec driver is now in a really good shape, but 
still needs some fine tuning to be close to perfect ;)

So yes, there will be more patches coming, but I'm not sure about the time line 
for those.

> Thanks
> 
> Liam
> 

-- 
Péter