[alsa-devel] [PATCH] ASoC: DaVinci: Fix stream restart error

Chaithrika U S chaithrika at ti.com
Wed Jan 20 13:07:05 CET 2010


All,

Please ignore this patch, missed the 'To' address in the mail.
I have re-submitted this patch.

Regards, 
Chaithrika

On Wed, Jan 20, 2010 at 17:04:45, alsa-devel at alsa-project.org wrote:
> From: Chaithrika U S <chaithrika at ti.com>
> 
> Sometimes after a suspend-resume cycle, the ALSA application
> restarts the stream when resume fails and McASP fails to work
> as the clock is not enabled. This patch corrects this bug.
> 
> Testes on TI DA850/OMAP-L138 EVM.
> 
> Signed-off-by: Chaithrika U S <chaithrika at ti.com>
> ---
> Applies to ALSA GIT tree on branch topic/asoc at
> http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=shortlog;
> h=topic/asoc
> 
>  sound/soc/davinci/davinci-mcasp.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index a613bbb..ab6518d 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -768,13 +768,12 @@ static int davinci_mcasp_trigger(struct snd_pcm_substream *substream,
>  
>  	switch (cmd) {
>  	case SNDRV_PCM_TRIGGER_RESUME:
> +	case SNDRV_PCM_TRIGGER_START:
> +	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
>  		if (!dev->clk_active) {
>  			clk_enable(dev->clk);
>  			dev->clk_active = 1;
>  		}
> -		/* Fall through */
> -	case SNDRV_PCM_TRIGGER_START:
> -	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
>  		davinci_mcasp_start(dev, substream->stream);
>  		break;
>  
> -- 
> 1.5.6
> 





More information about the Alsa-devel mailing list