[alsa-devel] [PATCH 2/2] Davinci: DM365: Enable DaVinci Voice Codec support for DM365 EVM

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Jan 8 12:31:22 CET 2010

On Thu, Jan 07, 2010 at 04:17:21PM -0600, miguel.aguilar at ridgerun.com wrote:

> +		if (device == 0)
> +			davinci_cfg_reg(DM365_EVT2_ASP_TX);
> +		else
> +			davinci_cfg_reg(DM365_EVT2_VC_TX);

I'd be a bit more comfortable with this if it were using something more
symbolic like a #define or enum rather than checking a bare number to
work out which device it's talking to.

Otherwise this looks good, but I've no familiarity with DaVinci
specifics so...

More information about the Alsa-devel mailing list