[alsa-devel] [patch] oxygen: clean up. make precedence explicit

Dan Carpenter error27 at gmail.com
Fri Feb 19 07:58:56 CET 2010

This doesn't change anything, but I think it makes the code clearer.  
It silences a smatch warning:
sound/pci/oxygen/oxygen_mixer.c +91 dac_mute_put(7) warn: add some parenthesis here?

Signed-off-by: Dan Carpenter <error27 at gmail.com>
Compile tested.

diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c
index f375b8a..28590b9 100644
--- a/sound/pci/oxygen/oxygen_mixer.c
+++ b/sound/pci/oxygen/oxygen_mixer.c
@@ -88,7 +88,7 @@ static int dac_mute_put(struct snd_kcontrol *ctl,
 	int changed;
-	changed = !value->value.integer.value[0] != chip->dac_mute;
+	changed = (!value->value.integer.value[0]) != chip->dac_mute;
 	if (changed) {
 		chip->dac_mute = !value->value.integer.value[0];

More information about the Alsa-devel mailing list