[alsa-devel] [PATCH -next] ASoC: pandora: Add DAC regulator support
lrg at slimlogic.co.uk
Fri Feb 5 16:16:50 CET 2010
On Fri, 2010-02-05 at 16:29 +0200, Grazvydas Ignotas wrote:
> On Fri, Feb 5, 2010 at 4:08 PM, Liam Girdwood <lrg at slimlogic.co.uk> wrote:
> > On Fri, 2010-02-05 at 15:13 +0200, Grazvydas Ignotas wrote:
> >> Pandora's external DAC is connected to VSIM TWL4030 supply, so let's
> >> start switching it too to save more power.
> >> Also DAC got it's own DAPM handler and the delay was removed
> >> (it gave on audible improvement).
> > That's good to hear (pun intended).
> Uh, I meant "no audible improvement". However I've just checked the
> DAC datasheet again and it requires 1ms delay between turning on/off
> the supply and switching /PD pin (connected to
> OMAP3_PANDORA_DAC_POWER_GPIO). Even though I hear no difference,
> adding the delays back just in case. Updated patch attached.
Btw, have you tried turning the volume to mute when the DAC is enabled.
It may lessen the pop at switch on.
Acked-by: Liam Girdwood <lrg at slimlogic.co.uk>
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
More information about the Alsa-devel