[alsa-devel] [PATCH 10/10] sound/soc/blackfin: Fix continuation line formats

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Feb 2 12:08:24 CET 2010

On Mon, Feb 01, 2010 at 11:13:04PM -0500, Mike Frysinger wrote:
> On Mon, Feb 1, 2010 at 12:08, Joe Perches wrote:

> > There are a few false positives and probably a few missing using

> >        grep -rP --include=*.[ch] '".*\\$' * | \
> >        awk '{ if ((gsub("\"", "\"") % 2) == 1) print $0; }'

> > Most of the uses are __asm__ __volatile__ which could be
> > considered unsightly but don't impact logging messages.

> > The rest could/should be fixed.

My point was that it'd be good to also check for just regular use of
continuations in code other than macro definitions.  These are just a
style nit but if there's a script that filters out false positives from
the macros that'd be handy...

> the Blackfin alsa fixes all look good to me, thanks

Running "grep ' \\$' sound/soc/blackfin/*.[ch]" suggests that there's
still some of the continuations I mentioned above in there (plus a lot
of false positives from macros).

More information about the Alsa-devel mailing list