[alsa-devel] [RFC 2/4] ASoC SST: Add mid platfrom driver

[Mark Brown]

On Tue, Dec 28, 2010 at 05:40:58PM +0530, Koul, Vinod wrote:

> +	/*.suspend	= intelmid_platform_suspend,
> +	.resume		= intelmid_platform_resume,*/

Remove the commented out code until it's implemeneted.

> +MODULE_DESCRIPTION("ASoC Intel(R) PLATFORM driver");
> +MODULE_AUTHOR("Harsha Priya");
> +MODULE_LICENSE("GPL v2");

MODULE_ALIAS() too.

> +#define MIN_RATE		8000
> +#define MAX_RATE		48000
> +#define MIN_CHANNEL		1
> +#define MAX_CHANNEL_AMIC	2
> +#define MAX_CHANNEL_DMIC	5
> +#define MAX_BUFFER		(800*1024)
> +#define MIN_BUFFER		(800*1024)
> +#define MIN_PERIOD_BYTES	32
> +#define MAX_PERIOD_BYTES	MAX_BUFFER
> +#define MIN_PERIODS		2
> +#define MAX_PERIODS		(1024*2)
> +#define FIFO_SIZE		0
> +#define MSIC_VENDOR_ID          0x3
> +#define SST_CARD_NAMES "intel_mid_card"

These pretty much all need namespacing; given that they're only used in
one place for the most part it'd seem as well to just not bother having
defines for them in the first place.

> +enum mid_drv_status {
> +	INIT = 1,
> +	STARTED,
> +	RUNNING,
> +	PAUSED,
> +	DROPPED,
> +};
> +
> +/* device */
> +enum SND_INPUT_DEVICE {
> +	AMIC,
> +	DMIC,
> +	HS_MIC,
> +	IN_UNDEFINED
> +};

Namespacing here too; it seems very odd that the CPU would care what's
connected to it.

> +void period_elapsed(void *mad_substream)
> +{

Staticise this or namespace it if it's used externally.