[alsa-devel] dev_info() argument in sound/soc/soc_dapm.c

Takashi Iwai tiwai at suse.de
Wed Dec 22 15:06:44 CET 2010


my build tests caught a warning regarding the conversion to dev_info()
in soc-dapm.c.  dev_info() is printf style, thus you shouldn't pass
the expanded string to the format argument.

I applied the following patch to topic/asoc branch.



From 9d01df063e70260d6c0aabd58dd5507db151aa51 Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai at suse.de>
Date: Wed, 22 Dec 2010 14:08:40 +0100
Subject: [PATCH] ASoC: don't pass the string as the format arguemtn for dev_info()

Signed-off-by: Takashi Iwai <tiwai at suse.de>
 sound/soc/soc-dapm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 50f5c78..499730a 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -110,7 +110,7 @@ static void pop_dbg(struct device *dev, u32 pop_time, const char *fmt, ...)
 	va_start(args, fmt);
 	vsnprintf(buf, PAGE_SIZE, fmt, args);
-	dev_info(dev, buf);
+	dev_info(dev, "%s", buf);

More information about the Alsa-devel mailing list