[alsa-devel] [PATCH 4/4] ASoC: clean up cache accesser

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Dec 20 17:42:02 CET 2010

On Mon, Dec 20, 2010 at 05:05:51PM +0100, Takashi Iwai wrote:

> Erm, subject might be wrong, but I'm too dizzy now.

I think you just mean "Factor out cache accesses" or something?

> +static inline bool set_cache_val(void *base, unsigned int idx,
> +				unsigned int val, unsigned int word_size)
> +{
> +	if (word_size == 1) {
> +		u8 *cache = base;

Like Dimitris says these really do need to be switch statements.
Otherwise it looks OK.

More information about the Alsa-devel mailing list