[alsa-devel] [PATCH v2 04/16] ASoC: twl6040: Set default gains to minimun value

Mark Brown broonie at opensource.wolfsonmicro.com
Sat Dec 11 13:48:54 CET 2010

On Fri, Dec 10, 2010 at 09:05:35PM -0600, Olaya, Margarita wrote:
> From: Jorge Eduardo Candelaria <jorge.candelaria at ti.com>
> Updated default values to improve power consumption.
> Signed-off-by: Jorge Eduardo Candelaria <jorge.candelaria at ti.com>
> Signed-off-by: Margarita Olaya Cabrera <magi.olaya at ti.com>

It'd be much more idiomatic to do this by having writes in the driver
startup path and adding comments to explain why the defaults are being
changed.  Altering the table with no explanation in the code means that
someone could quite easily come along later and correct the values back
to the actual chip defaults, and means that someone could get surprised
if they write code which assumes these are the actual chip defaults
later on.

More information about the Alsa-devel mailing list