[alsa-devel] [PATCH] ASoC: dapm: Add speaker driver widget.
lrg at slimlogic.co.uk
Tue Dec 7 13:46:28 CET 2010
On Tue, 2010-12-07 at 12:36 +0000, Mark Brown wrote:
> On Tue, Dec 07, 2010 at 12:34:45PM +0000, Liam Girdwood wrote:
> > On Mon, 2010-12-06 at 23:38 +0000, Mark Brown wrote:
> > > ...we don't need to change the ordering at all, we've already got a
> > > sequence point for this sort of widget we can use. We should just make
> > > the existing speaker and headphone widgets be in terms of one, I think.
> > The only minor problem here is that the current sequence point is name
> > "snd_soc_dapm_spk" which would seem confusing to haptic/vibra driver
> > users. Although, I can live with this....
> I meant the number in the sequence - the patch had the new widget coming
> up in the slot before the existing output driver widgets.
Ok, but by sharing the number we take away some flexibility in the
sequence ordering. Say something has to be done in the machine driver
_after_ the spk/haptic/vibra driver is enabled in the CODEC driver ?
I dont actually see any major issue of using a new number here unless
you have it reserved for something else ?
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
More information about the Alsa-devel