[alsa-devel] [PATCH] ASoC: When disabling WM8994 FLL force a source selection

Liam Girdwood lrg at slimlogic.co.uk
Fri Dec 3 18:07:03 CET 2010


On Fri, 2010-12-03 at 16:45 +0000, Mark Brown wrote:
> When we disable the WM8994 FLL code path sharing means that we end up
> writing out a configuration. Currently this is the currently active
> input and output frequency (which causes snd_soc_update_bits() to
> suppress actual writes both immediately and in the common case where
> we reenable the same configuration later) but we allow machine drivers
> to pass through a source of zero. Since the register values written
> are one less than the source constants this causes corruption of other
> bitfields in the register.
> 
> Fix this by using the most recently configured FLL source when none is
> provided.
> 
> Signed-off-by: Mark Brown <broonie at opensource.wolfsonmicro.com>
> ---

Acked-by: Liam Girdwood <lrg at slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk



More information about the Alsa-devel mailing list