[alsa-devel] [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id

Arnaud Patard (Rtp) arnaud.patard at rtp-net.org
Fri Dec 3 13:21:22 CET 2010

Axel Lin <axel.lin at gmail.com> writes:

> In alc5623_i2c_probe(),
> the default case for checking alc5623->id behaves the same as case 0x23.
> However, In alc5623_probe() the default case for checking alc5623->id
> becomes to be the same as case 0x21.
> This makes the meaning of default case inconsistent.
> Since we have checked codec id in alc5623_i2c_probe() by comparing
> vid2 with id->driver_data, it is not possible to run into the default case now.
> In case we may add more supported devices to alc5623_i2c_table in the future,
> this patch changes the default case return -EINVAL to let people know that
> they should not run into this case. They should also add a new case accordingly
> for the new id.

oh, yeah. makes sense. Thanks for noticing.

Acked-by: Arnaud Patard <arnaud.patard at rtp-net.org>

More information about the Alsa-devel mailing list