[alsa-devel] [PATCH 4/7] ASoC: Automatically calculate clock ratio for WM8580

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Aug 31 12:42:32 CEST 2010

On Tue, Aug 31, 2010 at 03:46:44PM +0900, Jassi Brar wrote:

> Ok, now that I am faced with supporting latest SMDKs that use codecs
> other than WM8580 (like wm8994), I think we'd better break the MACHINE
> driver into SMDK specific (setup CPU master, CODEC slave and
> root-clock sourced acc to option provided vai platform_data)
> and CODEC specific part.
> That will also help code reuse.

> Any opinions, before I start working on it?

If you're looking at this it'd be a good idea to look at pulling the
clocking configuration for the CPU into the CPU driver - the Samsung
CPU hardware is fairly straightforward and easy to use and it should be
possible to automate much more of the configuration, at least by
default.  At the minute there's a lot of cut'n'paste code for the
clocking configuration which could do with being shared.

In terms of the stuff that is genuinely board specific I'd need to look
at the designs and discuss the use cases with you to really comment in
too much detail.  The WM8994 is a vastly more flexible part and there's
a number of interesting things you can do with it that might result in a
noticably different clocking configuration from the machine driver,
especially around things like the analogue bypass cases and keeping the
the device active during suspend, but a lot of this depends on the
system design as a whole.

More information about the Alsa-devel mailing list