[alsa-devel] [PATCH 1/2] ASoC: uda1380: make driver more powersave-friendly
broonie at opensource.wolfsonmicro.com
Sat Aug 28 10:56:36 CEST 2010
On Sat, Aug 28, 2010 at 10:49:35AM +0300, Vasily Khoruzhick wrote:
> Disable some codec modules in standby mode, completely disable
> codec in off mode to save some power.
> Fix suspend/resume: mark mixer regs as dirty on resume to
> restore mixer values, otherwise driver produces no sound
> (master is muted by default).
This sounds like there's a pre-existing bug where the register cache
defaults don't correspond to the chip defaults. In general we always
keep the initial chip defaults for user visible controls in the driver
and let the application layer set the values it wants. This avoids
having to worry about defaults being inappropriate for some systems (eg,
volumes far too loud or bad output path selection) - normally the chip
defaults will be reasonable for first power up.
The code itself looks good from a quick read through.
More information about the Alsa-devel