[alsa-devel] purify_inactive_streams and Azalia controllers with >1 codec

[Takashi Iwai]

At Thu, 19 Aug 2010 14:58:07 -0700,
Stephen Warren wrote:
> 
> Takashi Iwai wrote:
> > 
> > At Thu, 19 Aug 2010 12:08:59 -0700,
> > Stephen Warren wrote:
> > >
> > > NVIDIA GPUs that contain Azalia controllers currently all have 1 controller,
> > > each having 4 codecs, each having 1 converter.
> > >
> > > I think there's a logic bug in hda_codec.c:purify_inactive_streams();
> > > streams are controller-wide, but purify_inactive_streams() only cleans up the
> > > converters a single codec as far as I can tell.
> > 
> >...
> > Below is a quick fix patch.  Could you give it a try?
> 
> Yes, that seems to work great.

Thanks for checking.  I'll merge it.

> Could you explain more why patch_atihdmi.c mostly calls snd_hda_multi_out_* yet
> patch_nvhdmi.c and patch_intelhdmi.c mostly call hdmi_*?

It's simply because patch_atihdmi.c is based on a very old code with
static configuration.  A few models in patch_nvhdmi.c do so by the
same reason :)

My plan is to merge all these three modules into a single generic
hdmi module.  I'll start merging ATI code to Intel since ATI HDMI
codecs are pretty simple.


Takashi