[alsa-devel] [PATCH] Add support for tlv320aic3007 to tlv320aic3x driver

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Aug 19 11:47:45 CEST 2010

On Thu, Aug 19, 2010 at 02:19:16PM +0800, Randolph Chung wrote:
> The attached patch adds support for the tlv320aic3007 codec to the
> tlv320aic3x driver.
> The tlv320aic3007 is similar to the aic31, but has an additional
> class-D speaker amp. The speaker amp control register overlaps with
> the mono output register of other codecs in this family, so we allow
> the board driver to pass in a model id to identify the codec being
> used.

Rather than passing something in the platform data you should use the
I2C device ID table for the device and have the board register the
device as a tlv320aic3007.

I would review the patch in more detail but you attached it as a base64
encoded attachment which means my MUA hasn't quoted it for me and won't
even display it unless I explicitly open it...  The main thing I noticed
was that you're using an enum instead of a TLV control for the amp

As I reminded you last time you always need to CC maintainers on
patches.  This is very helpful for ensuring that we actually see things
on busy lists and is helpful for keeping track of what needs reviewing.

More information about the Alsa-devel mailing list