[alsa-devel] [PATCH v6 0/1] A codec driver for the TI WL1273 FM Radio.

Matti J. Aaltonen matti.j.aaltonen at nokia.com
Thu Aug 19 08:57:43 CEST 2010

On Wed, 2010-08-18 at 15:45 +0200, ext Mark Brown wrote:
> > My mail was meant as a friendly remainder, I've more used to get replies
> > like: "thanks for reminding me"... 
> A friendly reminder if it looks like things have been forgotten is one
> thing, but a reminder after less than 24 hours doesn't come over as
> that.
> > But I sent the version five of the codec on the fifth of August and got
> > no comments to that either and then I sent version six just because I
> > had had a change to test it. So for me it was almost two weeks, which
> > still perfectly fine... I just sent that message with I thought was
> > perfectly unoffensive.
> You got comments on v5 - both Liam and myself replied to your v5 posting
> reminding you to update for multi-component.

We might as well have the facts right:

Above you are talking about v3 because v4 was the first multi component

And to that you (Mark) commented:

> This basically looks OK but...
> > +/* codec private data */
> > +struct wl1273_priv {
> > +     struct snd_soc_codec codec;
> > +     enum wl1273_mode mode;
> > +     struct wl1273_core *core;
> > +     unsigned int channels;
> > +};
> ...why would anything outside the driver be peering > into this?

Then I sent v5 (on 5 of Aug) to which I got no comment, then I sent v6
after being able to test the codec... And be because I hadn't heard you
in 13 days I wrote the unfortunate phrase: "I haven't heard you in a
while"... Which I meant as a form a small talk and of course as way to
get attention, which I got...


More information about the Alsa-devel mailing list