[alsa-devel] [PATCH 4/7] ASoC: Automatically calculate clock ratio for WM8580

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Aug 16 14:21:22 CEST 2010

On Mon, Aug 16, 2010 at 01:16:15PM +0900, Seungwhan Youn wrote:
> On Sat, Aug 14, 2010 at 4:35 AM, Mark Brown

So, this is a great example of a general problem with your mails: you're
generally very light on detail.  This makes it hard to work out exactly
what you're talking about.  This applies to both regular e-mails and
also patches where your descriptions also tend towards the terse.

> > +       switch (dai->driver->id) {
> > +       case WM8580_DAI_PAIFTX:
>     should be  WM8580_DAI_PAIFRX:

> Because, WM8580_DAI_PAIFTX --> Capture --> ADC.

Gah, right.

> > +       return snd_soc_update_bits(codec, WM8580_CLKSEL, sel, sel_mask);

> Seems the value and mask arguments are swapped ?


More information about the Alsa-devel mailing list