[alsa-devel] ASoC: Make ams-delta/cx20442 pair back working for multi-component
jkrzyszt at tis.icnet.pl
Fri Aug 13 21:10:33 CEST 2010
Wednesday 11 August 2010 15:42:31 Liam Girdwood napisał(a):
> On Wed, 2010-08-11 at 01:29 +0200, Janusz Krzysztofik wrote:
> > 1.
> > After a static codec pointer removal from the sound/soc/codecs/cx20442.c
> > code, both codec and card specific tty line discipline functions lost
> > their access to the codec structure data. Arrange for passing the pointer
> > back to the codec tty ldisc bits from the card initialization code.
> > 2.
> > Update incosistent codec device naming in the card code.
> > 3.
> > Since a new element, control_data, has been added to the cx20442_priv
> > structure, it looks like the old snd_soc_codec->control_data may be
> > scheduled for removal. To avoid problems in the near future, use the
> > cx20442_priv->control_data instead of the snd_soc_codec->control_data
> > throughout the cx20442 code. In the ams-delta card code, check for the
> > snd_soc_codec->hw_write not NULL instead of the
> > snd_soc_codec->control_data.
> > Created and tested on Amstrad Delta against
> > git://git.kernel.org/pub/scm/linux/kernel/git/lrg/asoc-2.6.git,
> > commit a212dd5b2e1da045cbf423c70c87f48265531de4.
> > Signed-off-by: Janusz Krzysztofik <jkrzyszt at tis.icnet.pl>
Thanks, and sorry for not commenting on time your related RFC posted in June.
I was not subscribed to the list.
BTW, what was the rationale for renaming the codec dai to "cx20422-hifi"?
While this doesn't break anything obviously, I think the hifi suffix is
missleading for a codec with a sampling rate of 8 kHz ;).
More information about the Alsa-devel