[alsa-devel] [PATCH 5/5] ASoc: add machine driver for 88pm860x

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Aug 13 16:26:46 CEST 2010

On Fri, Aug 13, 2010 at 09:55:53PM +0800, Haojian Zhuang wrote:
> From cd2063f68b233a86b24efa3f4dc3ca3c438b1576 Mon Sep 17 00:00:00 2001
> From: Haojian Zhuang <haojian.zhuang at marvell.com>
> Date: Thu, 12 Aug 2010 12:04:23 +0800

Please fix your configuration for sending patches - none of this header
stuff should be in the body of the mail.

> Subject: [PATCH 5/5] ASoc: add machine driver for 88pm860x

It's not a machine driver for this CODEC, it appears to be two machine
drivers for...

> 88PM860x codec is used in Marvell development board (Saarb and tavorevb3).
> Codec is used as master mode in both of these two boards.

...these two boards.  I'd suggest supplying one board per patch.

> +#include "../../arm/pxa2xx-pcm.h"


> +	SND_SOC_DAPM_SPK("Board Speaker", NULL),
> +	SND_SOC_DAPM_MIC("Board Mic 1", NULL),
> +	SND_SOC_DAPM_MIC("Board Mic 3", NULL),

What happened to Mic 2?

More information about the Alsa-devel mailing list