[alsa-devel] [PATCH 1/5] ASoC: Remove -dai suffix from Samsung DAI devices
broonie at opensource.wolfsonmicro.com
Fri Aug 13 14:29:15 CEST 2010
On Fri, Aug 13, 2010 at 08:20:22PM +0900, Seungwhan Youn wrote:
> On Fri, Aug 13, 2010 at 5:59 PM, Mark Brown
> > There's no change between -i2s and -iis introduced by this patch,
> > all this patch did was strip the -dai suffix from the names. It looks
> > like this is an error in the Aquilla driver which should be corrected.
> I see. I just think that this patch modify to fix naming of i2s
> platform driver with setting corresponding arm/arch like your
> modification of 'smdk64xx_wm8580.c' in this patch. I think that aquila
> board was wrong example, but I'm afraid that other boards which was
> modified cpu_dai_name from Liam's multi-comp patches, also look
> not-correct. Because I don't know they are using platform driver on
> arch/arm, but I think that they(other machine code, like
> jive_wm8750.c) use I2S driver named 's3c24xx-iis', 's3c2412-iis' and
Like I say this is an orthogonal issue to this patch.
> Of course, that things can be handled another patch with another guy
> who can verify its work. But, I think that fix on this patch will be
> more nice to me.
No, one patch for one change. With this sort of fairly wide patch it is
much easier to review if each line of the patch only does one thing so
that each change can be quickly compared against the single repetitive
change which is expected. If multiple changes are done in the same
commit then each line needs to be thought about more to determine if the
correct set of changes are being applied in that change.
More information about the Alsa-devel