[alsa-devel] [PATCH 1/2] ASoC: Set up debugfs only once per CODEC
broonie at opensource.wolfsonmicro.com
Fri Aug 13 11:02:49 CEST 2010
On Fri, Aug 13, 2010 at 07:42:44AM +0300, Peter Ujfalusi wrote:
> On Thursday 12 August 2010 17:50:31 ext Mark Brown wrote:
> > Since the debugfs directory is current per CODEC we should only init
> > it when the CODEC is initialised, otherwise we end up with errors
> > being generated when an attempt is made to add duplicate debugfs
> > entries.
> But if you move the init of debugfs where you have moved it, than the machine
> driver given DAPM widgets will have no debugfs entries, since the machine init
> is going to be called later (dai_link->init)...
Sure, but the big problem there is that these aren't really CODEC
> > Since most of this stuff is actually for the card we should refactor
> > but this can come later.
> Sure, refactoring will help, but with this change we have missing debugfs files
> for widgets, which is kind of confusing.
Meh, it's a debug facility and I hope it'll be sorted out within a week
or so anyway. Besides, you're not really loosing much information since
there tends to be no interesting routing outside the CODEC.
More information about the Alsa-devel