[alsa-devel] [Uclinux-dist-devel] [PATCH 5/6] ASoC: new ADAU1761 codec driver

[Mike Frysinger]

On Sat, Aug 7, 2010 at 18:16, Mark Brown wrote:
> On 7 Aug 2010, at 21:28, Mike Frysinger wrote:
>> +config SND_SOC_ADAU1761
>> +     tristate
>> +     select SIGMA
>> +
>
> What is SIGMA?

it's a new firmware loader that's standardized across SigmaDSP parts.
i (correctly) assumed this driver wasnt going to be accepted right
away, so i wanted to get feedback in parallel to the firmware loader
being merged.

>> +static ssize_t adau1371_dsp_load(struct device *dev,
>> +                               struct device_attribute *attr,
>> +                               const char *buf, size_t count)
>> +{
>> +     struct snd_soc_device *socdev = dev_get_drvdata(dev);
>> +     struct snd_soc_codec *codec = socdev->card->codec;
>> +     int ret = 0;
>> +
>> +     ret = adau1761_setprogram(codec);
>> +     if (ret)
>> +             return ret;
>> +     else
>> +             return count;
>> +}
>> +static DEVICE_ATTR(dsp, 0644, NULL, adau1371_dsp_load);
>
> This looks redundant - it doesn't offer any opportunity to configure the firmware to download and you're already (as one one would expect) automatically downloading the firmware. If this is being exposed at all it should be via debugfs.

SigmaDSP parts have the ability to change firmwares on the fly.  this
isnt a debug feature, it's somewhat core to these parts.  idea being
that you can load up different mini signal processing engines based on
the current needs.
-mike