[alsa-devel] [PATCH] ASoC: multi-comp: soc-core: Fix for machine given DAPM widgets

[Liam Girdwood]

On Thu, 2010-08-05 at 13:13 +0100, Mark Brown wrote:
> On Thu, Aug 05, 2010 at 09:07:50AM +0300, Peter Ujfalusi wrote:
> > Move the DAPM initialization after the machine driver has
> > finished it's init (dai_link driver).
> > Since in machine init we can add DAPM widgets we need to
> > take them into account as well.
> > 
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi at nokia.com>
> 
> Acked-by: Mark Brown <broonie at opensource.wolfsonmicro.com>
> 

Applied.

> but...
> 
> > @@ -1375,6 +1372,10 @@ static int soc_probe_dai_link(struct snd_soc_card *card, int num)
> >  		}
> >  	}
> >  
> > +	/* Make sure all DAPM widgets are instantiated */
> > +	snd_soc_dapm_new_widgets(codec);
> > +	snd_soc_dapm_sync(codec);
> > +
> >  	/* register the rtd device */
> >  	rtd->dev.init_name = rtd->dai_link->stream_name;
> >  	rtd->dev.release = rtd_release;
> 
> ...it'd be better to find a home for this that was per card rather than
> per link I guess, that way we only need to iterate through once during
> instantiation.  A bit irrelevant though given that it's hardly a hot
> path.

Agreed, lets tackle that as an incremental patch after the merge.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk