[alsa-devel] [PATCH v4 1/1] ASoC: TI WL1273 FM Radio Codec.

[Matti J. Aaltonen]

Hello.

On Wed, 2010-08-04 at 18:31 +0200, ext Mark Brown wrote:
> On Wed, Aug 04, 2010 at 12:42:59PM +0300, Matti J. Aaltonen wrote:
> > This is an ALSA codec for the Texas Instruments WL1273 FM Radio.
> 
> This basically looks OK but...
> 
> > +/* codec private data */
> > +struct wl1273_priv {
> > +	struct snd_soc_codec codec;
> > +	enum wl1273_mode mode;
> > +	struct wl1273_core *core;
> > +	unsigned int channels;
> > +};
> 
> ...why would anything outside the driver be peering into this?

Well, I see no reason... So I'll move it from the header to the c -file
and then it's fine?

Cheers,
Matti A.