[alsa-devel] [PATCH 2/3] ad193x: fix wrong register setting in ad193x_set_dai_fmt

Barry Song 21cnbao at gmail.com
Sat Apr 24 19:12:03 CEST 2010

On Fri, Apr 23, 2010 at 11:14 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Wed, Apr 21, 2010 at 05:36:48PM +0800, Barry Song wrote:
>> Signed-off-by: Barry Song <21cnbao at gmail.com>
> Please provide more detailed changelogs.  What is wrong with the
> register settings?  I've applied the patch for 2.6.35 since it doesn't
> apply on 2.6.34 but it'd have been very much more helpful if you'd said
> what the problem you were trying to fix is.
There was an error before. DAIFMT_FORMAT is controlled by adc_ctrl1
reg and DAIFMT_INV is controlled by adc_ctrl2 reg in ad193x. Old codes
set all by adc_ctrl2, then sometimes, when running "arecord | aplay",
ad193x is set to wrong mode, we can't hear anything.

More information about the Alsa-devel mailing list