[alsa-devel] USB transfer_buffer allocations on 64bit systems
stern at rowland.harvard.edu
Wed Apr 14 16:08:47 CEST 2010
On Wed, 14 Apr 2010, Pedro Ribeiro wrote:
> On 14 April 2010 11:09, Daniel Mack <daniel at caiaq.de> wrote:
> > Thanks! So the only thing I can do for now is submit exactly this patch.
> > At least, it helps you and it shouldn't break anything. The question
> > remains whether this type of memory should be used for all
> > transfer_buffers.
> Is there any chance you could push this to -stable? I don't care
> because I always use the latest kernel, but the next Debian stable and
> Ubuntu LTS are going to use 2.6.32.
No! Please don't do it: Don't submit the patch and _certainly_ don't
submit it to -stable. It doesn't fix anything; it only works around a
bug, and at the moment we don't even know if the bug is in the kernel
or in Pedro's hardware (and even though it affects two different
systems of his, nobody else has reported a similar problem). Papering
over it will only remove the incentive to fix it properly.
In addition, you'll most likely find that lots of Linux developers will
object vociferously to any proposed patch that uses GFP_DMA. That flag
is supposed to be _only_ for ISA devices, which really need it. By
limiting the memory allocation to the lowest 16 MB of physical memory,
it greatly increases the chances that the allocation will fail.
More information about the Alsa-devel