[alsa-devel] [PATCH] ALSA: hda - via - fix master mute and automute with VT1812/VT2002P
tiwai at suse.de
Wed Apr 14 14:42:44 CEST 2010
At Tue, 13 Apr 2010 15:38:53 -0300,
Herton Ronaldo Krzesinski wrote:
> On VIA VT1812/VT2002P, the "Master Front Playback Switch" doesn't mute
> first line-out. This is an issue, for example I saw a laptop with VT1812
> and only one line-out (main speaker) that doesn't mute main speaker,
> because the master switch doesn't act on first line-out, and first
> line-out nid in array is assigned to speaker as expected by autoconfig
> But there is one more issue also: main switches and automute code deal
> with mute on same Amp-Outs, which can cause conflicts, thus if you mute
> "Master Front Playback Switch" and remove headphone for example, it will
> not respect the mixer setting. To solve it, we can change the pin type
> instead of muting Amp-Out, which is done here.
The problem is rather that "Master Front" is a misleading name.
"Master Front" volume control exists for other VIA codecs because there
is another "Front" volume that is assigned to a pin widget.
So, this "Master" isn't really a master control.
IMO, a better way would be to rename this "Master Front" to either a
pin-specific one ("Speaker", etc), and make a vmaster control to bind
both this and headphone controls, like other codecs.
I'm going to try to implement it...
More information about the Alsa-devel