[alsa-devel] [PATCH 0/3] Usage of AM_SILENT_RULES and small cleanup

[Takashi Iwai]

At Tue, 29 Sep 2009 23:48:18 +0200,
Stefan Schmidt wrote:
> 
> Hello.
> 
> While working with alsa-lib to get scenarios in shape and submitted later I
> added support for the new automake feature AM_SILENT_RULES and did some small
> cleanups.
> 
> [PATCH 1/3] cvscompile: Remove in favour of gitcompile.
> I see no reason to keep this around when CVS is no longer used and gitcompile
> does replace it. Something I miss here?
> 
> [PATCH 2/3] configure.in: Add m4 check for new AM_SILENT_RULES
> The kbuild like output makes it a lot easier to follow the compile and linking
> process, at least in my opinion. It is available with automake 1.11 and we use a
> m4 macro here to only use it when it is available.
> 
> [PATCH 3/3] control: Remove unused variable.
> Found while really seeing what is going on thanks to AM_SILENT_RULES: ;)

Thanks, applied all patches now.

> There are also some unused paramter and a function around. I don't know how you
> guys prefer to handle this in the ALSA project so I did not prepare patches for
> this yet. Let me know if you want some for it.
> 
> pcm_route.c: In function ‘snd_pcm_route_convert1_many’:
> pcm_route.c:350: warning: ‘src’ may be used uninitialized in this function

I think this is false-positive, so let it be.

> pcm_rate_linear.c: In function ‘get_supported_rates’:
> pcm_rate_linear.c:408: warning: unused parameter ‘rate’
> pcm_rate_linear.c: In function ‘linear_dump’:
> pcm_rate_linear.c:416: warning: unused parameter ‘rate’
> pcm_rate_linear.c: In function ‘_snd_pcm_rate_linear_open’:
> pcm_rate_linear.c:435: warning: unused parameter ‘version’

These can be suppressed simply by adding ATTRIBUTE_UNUSED.

> alisp.c:237: warning: ‘incref_tree_explicit’ defined but not used

This can be commented out.

Care to send fix patches?


thanks,

Takashi