[alsa-devel] [PATCH 1/2] ASoC: DaVinci: Fix divide by zero error during 1st execution

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Sep 24 16:36:22 CEST 2009


On Wed, Sep 23, 2009 at 06:44:15PM -0700, Troy Kisky wrote:

> I think you were waiting for me to remove the need for the
> comment:

> +	/*
> +	 * dma_params must be first because rtd->dai->cpu_dai->private_data
> +	 * is cast to a pointer of an array of struct davinci_pcm_dma_params in
> +	 * davinci_pcm_open.
> +	 */

> Which is doable.

> Do you still want this fixed?

Yes, please - I merged the patch because the bug fix really ought to be
in .32 but it'd still be good to get the code cleaned up even if that
has to wait for .33.



More information about the Alsa-devel mailing list