[alsa-devel] [PATCH] S3C64XX I2S: Added machine driver for WM8580

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Sep 17 14:03:53 CEST 2009

On Thu, Sep 17, 2009 at 08:35:56PM +0900, jassi brar wrote:

> This note means stands for the forthcoming cases. The explanation is already
> given above the switch.

> /* Currently, WM8580 driver doesn't support PLL-out rates
>  * other than those mentioned in Table-52 Page-58 of WM8580A
>  * manual. Some of these unavailable rates include
>  * {8000x256, 64000x256, 11025x256}Hz.

Which version of the datasheet are you looking at?  Table 52 in the
current version 4.7 is (as it says) a list of example configurations,
not an exhaustive list of supported configurations.  Anything within the
operating characteristics of the PLL is supported, set_pll() should
enforce this where required.

> > All my previous comments about these and the way they're being
> > configured still apply.

> Once 6channel support is up, i will submit a patch to implement audio
> routing options
> using snd_soc_add_controls. Whereby user can set audio route on the device.
> For now, as we have only 2channels enabled, i decided to enable only Front-L/R
> and keep others disabled. Of the Mic and LineIn, we enable LineIn by
> default. How is that?

Please just remove this for now or at most enable everything by default,
like I say it's not buying anything except confusion as it stands.

If it's not present then the machine driver will immediately work when
six channel support is added.

More information about the Alsa-devel mailing list