[alsa-devel] [PATCH] S3C64XX I2S: Added machine driver for WM8580

[Mark Brown]

On Thu, Sep 17, 2009 at 01:54:13PM +0900, jassi brar wrote:

> +	/* Exceptions for this CPU-CODEC combination */
> +	case 64000:
> +		rfs = 384;
> +		break;

This needs to explain what the exceptions are for as well, otherwise
anyone working with the code is going to have to work it out from
scratch.

> +/* SMDK64xx Playback widgets */
> +static const struct snd_soc_dapm_widget wm8580_dapm_widgets_pbk[] = {
> +	SND_SOC_DAPM_HP("Front-L/R", NULL),
> +	SND_SOC_DAPM_HP("Center/Sub", NULL),
> +	SND_SOC_DAPM_HP("Rear-L/R", NULL),
> +};

All my previous comments about these and the way they're being
configured still apply.