[alsa-devel] [PATCH] WM8580 DAI: Debugged
broonie at opensource.wolfsonmicro.com
Mon Sep 14 14:06:48 CEST 2009
On Sat, Sep 12, 2009 at 05:05:37PM +0900, jassisinghbrar at gmail.com wrote:
> From: Jassi <jassi.brar at samsung.com>
> Debugged improper definition of 'struct snd_soc_dai wm8580_dai'
> Also, implemented various clock sourcing options for WM8580 blocks.
There's several problems here which mean I'm unable to apply the patch.
The biggest issue, which seems to apply to many of your patches (not
just the ones you've sent to me), is that you've combined several
unrelated changes into a single patch. This is generally considered to
be poor practice. It makes patches harder to review and apply,
especially when parts need to be applied in different places, and makes
the history less useful.
It would also be very helpful if you could devote more effort to your
changelogs - for example, you have not explained what the issue you
believe you are addressing in the DAI definition is. Looking at the
patch I suspect there has been a misunderstanding somewhere along the
More information about the Alsa-devel