[alsa-devel] [PATCH] RFC: ASoC: Davinci: Fix data_type divide by zero

Troy Kisky troy.kisky at boundarydevices.com
Fri Sep 11 23:27:18 CEST 2009

Mark Brown wrote:
> On Wed, Sep 09, 2009 at 06:57:10PM -0700, Troy Kisky wrote:
>> This applies on top of my last patchset to Kevin's temp/asoc branch
> Could you please respin against what's in for-2.6.32 - this ought to get
> fixed there but the other changes will need to wait for 2.6.33.
>>  struct davinci_mcbsp_dev {
>> +	/*
>> +	 * dma_params must be first because rtd->dai->cpu_dai->private_data
>> +	 * is cast to an array of struct davinci_pcm_dma_params ** in
>> +	 * davinci_pcm_open.
>> +	 */
> Is it not possible to deal with this by going through the types
> properly?  The comment sets off all sorts of alarm bells.

private_data will be either struct davinci_mcbsp_dev or
struct davinci_audio_dev

So, I moved dma_params to be 1st in both structures and added
a comment so that noone will move it.

Btw, I'm about to submit another rev of this against your for32
branch. But your branch currently give compile errors, so it
my compile test just doesn't generate new errors.


More information about the Alsa-devel mailing list