[alsa-devel] [PATCH] ASoC: Factor out I2C 8 bit address 8 bit data I/O

Takashi Iwai tiwai at suse.de
Mon Sep 7 12:52:37 CEST 2009

At Mon, 7 Sep 2009 11:50:06 +0100,
Mark Brown wrote:
> On Mon, Sep 07, 2009 at 12:40:02PM +0200, Takashi Iwai wrote:
> > Where we are at it: Mark, could you fix the initialization of io_types[]
> > in C99 style?  For this case, C99 style initialization is suited better
> > since some fields are optional now.
> Meh, I guess.
> > Also, I find the current unbalanced hw_read/hw_write definitions uneasy.
> > hw_read takes the codec instance while hw_write takes i2c instance
> > (and hw_read_t is dead).  It'd be nice if you can fix these as well.
> I don't think it's worth the pain until more of the drivers are using
> the shared cache functions - making changes like that more
> straightforward is one of the goals of doing this refactoring.

OK, but at least hw_read_t should be removed or fixed :)



More information about the Alsa-devel mailing list