[alsa-devel] [PATCH] ASoC: Factor out I2C 8 bit address 8 bit data I/O

Takashi Iwai tiwai at suse.de
Mon Sep 7 12:40:02 CEST 2009

At Mon, 7 Sep 2009 11:15:19 +0100,
Mark Brown wrote:
> On Mon, Sep 07, 2009 at 12:04:37PM +0900, Joonyoung Shim wrote:
> > This patch is for the AK4671 codec driver using this format.
> > Signed-off-by: Joonyoung Shim <jy0922.shim at samsung.com>
> Applied, thanks.

Where we are at it: Mark, could you fix the initialization of io_types[]
in C99 style?  For this case, C99 style initialization is suited better
since some fields are optional now.

Also, I find the current unbalanced hw_read/hw_write definitions uneasy.
hw_read takes the codec instance while hw_write takes i2c instance
(and hw_read_t is dead).  It'd be nice if you can fix these as well.



More information about the Alsa-devel mailing list