[alsa-devel] [PATCH] Minor WM8580 enhancements.

Mark Brown broonie at opensource.wolfsonmicro.com
Sun Sep 6 03:22:33 CEST 2009

On Sun, Sep 06, 2009 at 09:09:41AM +0900, jassi brar wrote:

> +	case WM8580_MCLKRATIO:
> +	case WM8580_BCLKRATIO:

There should be no need for machine drivers to configure any of this,
there's already enough information in the CODEC driver to figure out
this configuration without their help.  Having the machine drivers do it
manually simply forces each machine driver using the chip to repeat the
same logic which is at best redundant and at worst makes machine drivers
harder to write.

As mentioned previously this driver could use a bit of modernisation in
general, including with regard to clocking, which I had already been
planning to do as part of working on the SMDK boards.  As a result of
some work on another chip with a very similar clocking structure I have
a rough draft of what needs doing for the clocks already.  This is part
of why in my earlier mail I had recommended focusing on the CPU DAI
drivers for now - the lack of them is the biggest obstacle to getting
that work cleaned up and tested.

More information about the Alsa-devel mailing list