[alsa-devel] [PATCH 2/3] ASoC: DaVinci: pcm, rename variables in prep for ping/pong
troy.kisky at boundarydevices.com
Fri Sep 4 00:38:47 CEST 2009
David Brownell wrote:
> On Thursday 03 September 2009, Troy Kisky wrote:
>> David Brownell wrote:
>>> On Monday 31 August 2009, Troy Kisky wrote:
>>>> - int master_lch; /* Master DMA channel */
>>>> - int slave_lch; /* linked parameter RAM reload slot */
>>>> + int asp_master_lch; /* Master DMA channel */
>>>> + int asp_link_lch; /* asp parameter link channel, ping/pong */
>>> If you're going to rename things, may I suggest getting
>>> rid of "lch" ... use either "channel" or "link", since
>>> those are the two basic hardware roles in EDMA.
>> I agree, but can that be a separate patch...
> However you like; I'd just suggest that *one* rename-things
> patch is normally preferred. If this one's already in the
> merge queue that might be awkward.
Is the window too close, or is there time to change this?
More information about the Alsa-devel