[alsa-devel] [PATCH 2/3] ASoC: DaVinci: pcm, rename variables in prep for ping/pong

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Sep 3 00:01:53 CEST 2009


On Mon, Aug 31, 2009 at 04:31:44PM -0700, Troy Kisky wrote:
> Rename variable master_lch to asp_master_lch
> Rename variable slave_lch to asp_link_lch[0]
> Rename local variables:
> 	count to asp_count
> 	src to asp_src
> 	dst to asp_dst

These other two patches are OK but I'll wait for after the merge window
to apply them partly due to the dependency on the merged tree and also
since it's very near to the merge window opening and there's already
been a fair bit of churn and testing with the DaVinci drivers for
2.6.32.

I'll probably also apply the first patch since nobody else seems to care
one way or another, but I would urge you to look at changing the default
for the platform data to at most select the workaround only on CPUs that
have problems with channel swapping - it's going to cause confusion for
people to have it on by default.


More information about the Alsa-devel mailing list