[alsa-devel] [patch] snd-pcsp fixes

Takashi Iwai tiwai at suse.de
Fri Oct 30 12:14:46 CET 2009

At Wed, 21 Oct 2009 21:43:03 +0400,
Stas Sergeev wrote:
> [1  <text/plain; UTF-8 (7bit)>]
> Hi.
> The attached patch fixes the
> problems introduced in this commit:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=eea0579fc85e64e9f05361d5aacf496fe7a151aa
> - Fix nForce workaround by honouring
> the pointer_update var
> - Revert "ns" to u64, as per the hrtimer
> - Revert to the zero-delay timer startup,
> since I can't reproduce any problem
> with it (please, give me the hint!)
> Signed-off-by: Stas Sergeev <stsp at aknet.ru>
> Takashi, could you please apply or
> tell me where the problem is/was?
> Or, alternatively, we can revert the
> commit entirely, and then re-do the
> cleanups.

I applied the patch now as is, as I suppose you tested it well :)

I don't remember exactly the changes for pcsp driver right now,
but the change of the initial delay was due to the change of start
logic.  At least, at the time HRTIMER_CB_IRQSAFE was removed, starting
with zero didn't work at all on my machine.  Maybe something got fixed
in the core side.

But, I still don't understand why it has to be zero.  The first
bit-flip is done inside the trigger-start, so the next wakeup should
be after the calculated ns.  Isn't it?



More information about the Alsa-devel mailing list