[alsa-devel] [PATCH] OMAP: McBSP: Do not use extensive spin locks for dma_op_mode

Eero Nurkkala ext-eero.nurkkala at nokia.com
Tue Oct 27 12:07:23 CET 2009

On Tue, 2009-10-27 at 12:00 +0100, Ujfalusi Peter (Nokia-D/Tampere)
> The use of the spin lock, which supposed to protect the the
> dma_op_mode causing "INFO: inconsistent lock state" on
> playback start.
> Remove the spin locks around the dma_op_mode, when it's
> purpuse is to protect the dma_op_mode.
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi at nokia.com>
> ---

You may wish to double read the message above, as it's quite
confusing =)

Otherwise, that spinlocking is highly unnecessary and things are
far better without than with it. The only case it could be useful
is in SMPs, but OMAPs are not such quite yet - and when they
are, things will need to be re-though anyway.

- Eero

More information about the Alsa-devel mailing list